Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove caching as data is now fetched instantly anyway #36

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

OLILHR
Copy link
Member

@OLILHR OLILHR commented Jan 8, 2025

also, all tables for every +/- 5 years are not loaded at once anymore, significantly reducing the intial loading time. just like the legacy page now :)

@OLILHR OLILHR requested review from hf-kklein and hf-nsoeker January 8, 2025 23:14
@github-actions github-actions bot added the chore label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-ocean-076b69903-36.westeurope.4.azurestaticapps.net

@hf-kklein hf-kklein requested a review from a team January 9, 2025 07:22
Copy link

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, aber frag jemandem mit frontend-expertise, wenn du eine echte review willst ;)

});
const response = await fetch(requestUrl, {
method: "GET",
mode: "cors",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was macht dieser mode: "cors"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point; ist actually obsolet, weil das der default fetching mode ist, wenn die azure functions angesprochen werden. habs entfernt.

Copy link

github-actions bot commented Jan 9, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-ocean-076b69903-36.westeurope.4.azurestaticapps.net

@OLILHR OLILHR merged commit 8a7d879 into main Jan 9, 2025
8 checks passed
@OLILHR OLILHR deleted the chore/remove-caching branch January 9, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants